Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [NODE-1441] Upgrade GuestOS to 24.04 #938

Merged
merged 16 commits into from
Sep 30, 2024
Merged

feat: [NODE-1441] Upgrade GuestOS to 24.04 #938

merged 16 commits into from
Sep 30, 2024

Conversation

Bownairo
Copy link
Member

@Bownairo Bownairo commented Aug 14, 2024

Switch GuestOS over to a Ubuntu 24.04 base image. These changes will be initially rolled out in an RC.

@github-actions github-actions bot added the feat label Aug 14, 2024
@Bownairo Bownairo changed the title feat: Upgrade images feat: Upgrade images to 24.04 Aug 14, 2024
@raymondk raymondk changed the title feat: Upgrade images to 24.04 feat(NODE-1441): Upgrade images to 24.04 Aug 16, 2024
@Bownairo Bownairo changed the title feat(NODE-1441): Upgrade images to 24.04 feat: [NODE-1441] Upgrade images to 24.04 Aug 16, 2024
@Bownairo Bownairo marked this pull request as ready for review August 19, 2024 16:10
@Bownairo Bownairo requested review from a team as code owners August 19, 2024 16:10
@Bownairo Bownairo marked this pull request as draft August 26, 2024 14:18
@tmu0
Copy link
Contributor

tmu0 commented Aug 26, 2024

hi @Bownairo could you please merge master into your branch before running Schedule Daily again?

@Bownairo
Copy link
Member Author

hi @Bownairo could you please merge master into your branch before running Schedule Daily again?

Sorry, will do. Is this a one time thing or should I not be running this schedule? I'm mostly looking to trigger bazel-test-bare-metal and some of the performance tests.

@tmu0
Copy link
Contributor

tmu0 commented Aug 26, 2024

@Bownairo the reason is that we had a configuration error in the dependency scanner that causes it to run on arbitrary branches instead of just master. The fix is on master, i.e., when this is merged nothing speaks against running schedule daily on your custom branch from my side (I don't know that the other jobs are doing though).

@Bownairo Bownairo changed the title feat: [NODE-1441] Upgrade images to 24.04 feat: [NODE-1441] Upgrade GuestOS to 24.04 Sep 11, 2024
github-merge-queue bot pushed a commit that referenced this pull request Sep 16, 2024
As part of #938, we first need to
update and push the base images.
Fix bash symlink

Co-authored-by: Saša Tomić <[email protected]>
@Bownairo Bownairo marked this pull request as ready for review September 30, 2024 19:50
@Bownairo Bownairo added this pull request to the merge queue Sep 30, 2024
Merged via the queue into master with commit 87ed927 Sep 30, 2024
25 checks passed
@Bownairo Bownairo deleted the eero/upgrade-1 branch September 30, 2024 20:18
LittleChimera pushed a commit that referenced this pull request Oct 4, 2024
Bownairo added a commit that referenced this pull request Oct 17, 2024
pietrodimarco-dfinity pushed a commit that referenced this pull request Oct 18, 2024
sasa-tomic pushed a commit that referenced this pull request Oct 24, 2024
NikolaMilosa pushed a commit that referenced this pull request Oct 31, 2024
sasa-tomic pushed a commit that referenced this pull request Nov 7, 2024
DFINITYManu pushed a commit that referenced this pull request Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants