Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: EXC-1691: Reserve cycles just for the increase of canister snapshot size #960

Merged
merged 3 commits into from
Aug 26, 2024

Conversation

berestovskyy
Copy link
Contributor

@berestovskyy berestovskyy commented Aug 15, 2024

When replacing a snapshot, cycles should be reserved only for the increase in canister snapshot size.

Closes EXC-1691

@github-actions github-actions bot added the chore label Aug 15, 2024
@berestovskyy berestovskyy force-pushed the andriy/exc-1691-reserve-snapshot-increase branch 2 times, most recently from 7618adf to 4e91567 Compare August 15, 2024 16:13
@berestovskyy berestovskyy force-pushed the andriy/exc-1691-reserve-snapshot-increase branch from 4e91567 to 694614a Compare August 19, 2024 10:02
@berestovskyy berestovskyy changed the title chore: EXC-1691: Reserve cycles just for the canister snapshot increase chore: EXC-1691: Reserve cycles just for the increase of canister snapshot size Aug 20, 2024
Copy link
Member

@venkkatesh-sekar venkkatesh-sekar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@berestovskyy berestovskyy marked this pull request as ready for review August 20, 2024 09:40
@berestovskyy berestovskyy requested a review from a team as a code owner August 20, 2024 09:40
@berestovskyy berestovskyy added this pull request to the merge queue Aug 26, 2024
Merged via the queue into master with commit 9a84997 Aug 26, 2024
23 checks passed
@berestovskyy berestovskyy deleted the andriy/exc-1691-reserve-snapshot-increase branch August 26, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants