-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(PocketIC): VerifiedApplication subnets #963
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mraszyk
commented
Aug 16, 2024
mraszyk
commented
Aug 16, 2024
…#872) This MR proposes the following changes: 1. Delete the transaction table 2. Consolidate both block and transaction table content into a single table --------- Co-authored-by: maciejdfinity <[email protected]>
This MR proposes the following changes: 1. Remove the maximum number of accounts from the upgrade arguments This change is done, to close a possible vulnerability where the maximum number of accounts is set to 0 or a very small number.
mbjorkqvist
approved these changes
Aug 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why finint
wasn't removed as a reviewer after the changes from the other PR that did touch some Rosetta tests was merged in, but I'm happy to approve in case our approval still needed.
michael-weigelt
approved these changes
Aug 20, 2024
levifeldman
pushed a commit
to levifeldman/ic
that referenced
this pull request
Oct 1, 2024
This PR adds support for verified application subnets to PocketIC. --------- Co-authored-by: NikolasHai <[email protected]> Co-authored-by: maciejdfinity <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for verified application subnets to PocketIC.