Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(PocketIC): VerifiedApplication subnets #963

Merged
merged 10 commits into from
Aug 20, 2024
Merged

feat(PocketIC): VerifiedApplication subnets #963

merged 10 commits into from
Aug 20, 2024

Conversation

mraszyk
Copy link
Contributor

@mraszyk mraszyk commented Aug 16, 2024

This PR adds support for verified application subnets to PocketIC.

@mraszyk mraszyk requested a review from a team as a code owner August 16, 2024 06:00
@github-actions github-actions bot added the feat label Aug 16, 2024
mraszyk and others added 5 commits August 16, 2024 11:51
@mraszyk
Update packages/pocket-ic/CHANGELOG.md
b443abb
@NikolasHai @maciejdfinity @mraszyk
chore(ICP-Rosetta): FI-1419: icp rosetta database table consolidation (…
0b5c0c6 
…#872)

This MR proposes the following changes:

1. Delete the transaction table
2. Consolidate both block and transaction table content into a single
table

---------

Co-authored-by: maciejdfinity <[email protected]>
@NikolasHai @mraszyk
chore(ICP-Ledger): FI-1426: remove maximum number of accounts (#972)
212aaa6 
This MR proposes the following changes: 

1. Remove the maximum number of accounts from the upgrade arguments

This change is done, to close a possible vulnerability where the maximum
number of accounts is set to 0 or a very small number.
@mraszyk
feat(PocketIC): artificial delay in auto progress mode of PocketIC (#970
08211fd 
)

This PR adds support for an artificial delay in auto progress mode of
PocketIC specifying the minimum delay between consecutive rounds in auto
progress mode.
@mraszyk
changelog
496affe
@mraszyk mraszyk requested a review from a team as a code owner August 16, 2024 13:42
mbjorkqvist
mbjorkqvist approved these changes Aug 16, 2024
View reviewed changes
Copy link
Member

@mbjorkqvist mbjorkqvist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why finint wasn't removed as a reviewer after the changes from the other PR that did touch some Rosetta tests was merged in, but I'm happy to approve in case our approval still needed.

@mraszyk mraszyk added this pull request to the merge queue Aug 20, 2024
Merged via the queue into master with commit 268967e Aug 20, 2024
23 checks passed
@mraszyk mraszyk deleted the mraszyk/pic-verified-application branch August 20, 2024 13:49
levifeldman pushed a commit to levifeldman/ic that referenced this pull request Oct 1, 2024
@mraszyk @NikolasHai
@maciejdfinity @levifeldman
feat(PocketIC): VerifiedApplication subnets (dfinity#963)
80736d6 
This PR adds support for verified application subnets to PocketIC.

---------

Co-authored-by: NikolasHai <[email protected]>
Co-authored-by: maciejdfinity <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbjorkqvist mbjorkqvist mbjorkqvist approved these changes

@michael-weigelt michael-weigelt michael-weigelt approved these changes

Assignees
No one assigned
Labels
feat @finint @pocket-ic
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mraszyk @mbjorkqvist @michael-weigelt @NikolasHai