Skip to content
This repository has been archived by the owner on Nov 19, 2024. It is now read-only.

feat: System API method in_replicated_execution #231

Merged
merged 3 commits into from
Oct 10, 2023

Conversation

bogwar
Copy link
Contributor

@bogwar bogwar commented Sep 27, 2023

This PR adds a system API method to determine if the canister is running in replicated or non replicated mode.

@bogwar bogwar requested a review from a team as a code owner September 27, 2023 17:59
@github-actions
Copy link

github-actions bot commented Sep 27, 2023

🤖 Here's your preview: https://phnfe-kyaaa-aaaak-qckia-cai.icp0.io/docs

@bogwar bogwar requested review from dsarlis and mraszyk September 27, 2023 18:00
spec/index.md Show resolved Hide resolved
spec/index.md Show resolved Hide resolved
Copy link
Member

@dsarlis dsarlis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally lgtm.

One minor comment I also mentioned to Bogdan offline is whether replicated execution is an established term in the spec. I know that most of us understand what it means but I am not sure if that would be clear to someone who's reading the spec.

@mraszyk
Copy link
Contributor

mraszyk commented Sep 29, 2023

whether replicated execution is an established term in the spec

there are already a few occurrence, but all seem to be added recently

@bogwar bogwar changed the title System API method in_replicated_execution feat: System API method in_replicated_execution Oct 2, 2023
@bogwar
Copy link
Contributor Author

bogwar commented Oct 2, 2023

Generally lgtm.

One minor comment I also mentioned to Bogdan offline is whether replicated execution is an established term in the spec. I know that most of us understand what it means but I am not sure if that would be clear to someone who's reading the spec.

This was a very good point; I checked and we didn't actually introduce these terms properly so I've added a small clarification in the nomenclature section.

@bogwar bogwar merged commit e9cf725 into master Oct 10, 2023
2 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants