Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the min-width a bit smaller for mobile #2119

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

meodai
Copy link
Collaborator

@meodai meodai commented Dec 7, 2023

To avoid overflow issues on smaller phones


🟢 Some screens were added
🟡 Some screens were changed

@meodai
Copy link
Collaborator Author

meodai commented Dec 7, 2023

@nmattia Doing this will make the screens tighter on all smaller devices.

@nmattia
Copy link
Collaborator

nmattia commented Dec 7, 2023

@meodai can't we keep the current size but limit the text width for that one problematic screen? sacrificing real estate on all screens just for one loader seems a bit odd

@meodai
Copy link
Collaborator Author

meodai commented Feb 13, 2024

@nmattia I don't see how we are sacrificing real-estate. Min-width is only the minimum size the container should have, if it has more content it gets wider. The text-width is not the issue on that particular screen.

Copy link
Collaborator

@nmattia nmattia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I think I misunderstood the issue! Found it odd that all screens had to be impacted. Rubber stamp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants