feat: allow persistent? actor to switch default and transient as synonym for flexible
#4786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onym for flexible (persistent is not a synonym of stable)
crusso
commented
Nov 29, 2024
crusso
commented
Nov 29, 2024
crusso
commented
Nov 29, 2024
crusso
commented
Nov 29, 2024
crusso
commented
Nov 29, 2024
crusso
commented
Nov 29, 2024
….com:dfinity/motoko into claudio/stable-default-progdec-keywords-simp
|
Thank you for this PR! |
Maybe let me take a pass first before getting @jessiemongeon1 involved. She has tons on her plate and it might be quicker for me to revise the relevant bits. |
crusso
commented
Dec 2, 2024
luc-blaeser
previously approved these changes
Dec 3, 2024
* adapt manual * upgrade examples * revert change to intro examples * revert Counter.mo * tweaks * more tweaks * more tweaks * more tweaks * more * fix message-inspection linenumbers * more tweaks * Update doc/md/reference/language-manual.md * Update doc/md/writing-motoko/writing-intro.md * Update doc/md/canister-maintenance/upgrades.md Co-authored-by: Gabor Greif <[email protected]> * Update doc/md/examples/CardShuffle.mo Co-authored-by: Gabor Greif <[email protected]> * Update doc/md/examples/PersistentCounter.mo Co-authored-by: Gabor Greif <[email protected]> * Update doc/md/examples/RawRand.mo Co-authored-by: Gabor Greif <[email protected]> * Apply suggestions from code review Co-authored-by: Gabor Greif <[email protected]> * Update doc/md/canister-maintenance/compatibility.md Co-authored-by: Jessie Mongeon <[email protected]> * Update doc/md/canister-maintenance/upgrades.md Co-authored-by: Jessie Mongeon <[email protected]> * Update doc/md/canister-maintenance/upgrades.md Co-authored-by: Jessie Mongeon <[email protected]> * Apply suggestions from code review Co-authored-by: Jessie Mongeon <[email protected]> * Apply suggestions from code review Co-authored-by: Jessie Mongeon <[email protected]> --------- Co-authored-by: Gabor Greif <[email protected]> Co-authored-by: Jessie Mongeon <[email protected]>
crusso
changed the title
ggreif
changed the title
persistent? actor to switch default and transient as synonym for flexible
ggreif
reviewed
Dec 4, 2024
ggreif
reviewed
Dec 4, 2024
ggreif
previously approved these changes
Dec 4, 2024
Co-authored-by: Gabor Greif <[email protected]>
ggreif
approved these changes
Dec 5, 2024
|
@Mergifyio update |
☑️ Nothing to do
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the simplest solution with least grammar irregularities and probably least required doc changes.
persistentandtransient.transientis a synonym forflexible.persistent? actor (class) ...flips the default fromflexibletostable.Parses nicely because there is no any longer ambiguity between
stable/flexibleuses as object modifier or visibility. That means we don't need fancy and confusing grammar factoring.