Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(frontend): Use Zod for Network type #3251

Merged
merged 1 commit into from
Oct 31, 2024
Merged

feat(frontend): Use Zod for Network type #3251

merged 1 commit into from
Oct 31, 2024

Conversation

AntonioVentilii-DFINITY
Copy link
Contributor

@AntonioVentilii-DFINITY AntonioVentilii-DFINITY commented Oct 31, 2024 •
edited
Loading

Motivation

We change Network type to use Zod directly.

@AntonioVentilii-DFINITY AntonioVentilii-DFINITY marked this pull request as ready for review October 31, 2024 09:27
@AntonioVentilii-DFINITY AntonioVentilii-DFINITY requested a review from a team as a code owner October 31, 2024 09:27
@AntonioVentilii-DFINITY AntonioVentilii-DFINITY mentioned this pull request Oct 31, 2024
Merged
peterpeterparker
peterpeterparker approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@peterpeterparker peterpeterparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx

src/frontend/src/lib/types/network.ts
id: NetworkIdSchema,
env: NetworkEnvironmentSchema,
name: z.string(),
icon: z.string().optional(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not for this PR but, should we be a bit more expressive on the type of the icons?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, define the type of string for icons, I will have a look

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done with:

@AntonioVentilii-DFINITY AntonioVentilii-DFINITY merged commit 58b9d12 into main Oct 31, 2024
11 checks passed
@AntonioVentilii-DFINITY AntonioVentilii-DFINITY deleted the feat(frontend)/Use-Zod-for-Network-type branch October 31, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AntonioVentilii AntonioVentilii AntonioVentilii left review comments

@peterpeterparker peterpeterparker peterpeterparker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AntonioVentilii-DFINITY @peterpeterparker @AntonioVentilii