feat(frontend): add resetAll to initTransactionsStore #3606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -64,6 +65,7 @@ export const initTransactionsStore = < | |||
| [tokenId]: null | |||
| })), | |||
| reset, | |||
| resetAll: () => update(() => ({})), | |||
There was a problem hiding this comment.
We generally use null for reset because it explicitly indicates a decision to reset, such as when an error occurs. However, in this case, you are setting to the initial value, which creates a slight discrepancy.
There was a problem hiding this comment.
I was trying to replicate what is happening for the ETH transactions store too. But for sure I can set null on this, and then, in another PR, I adjust that store too
There was a problem hiding this comment.
I would say so, makes sense?
There was a problem hiding this comment.
just to clarify, that means setting null in all keys, like {tokenId1: null, tokenId2: null, ...}, and NOT that the entire store is null instead of {}
correct?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Mostly for testing purposes, it is useful to have a way of "resetting" the entire transaction store.