Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): filter carousel dApps using user profile #3811

Merged

Conversation

AntonioVentilii
Copy link
Collaborator

Motivation

With PR #3770 , we introduces a list of hidden dApps in the carousel, saved in the user profile.

Now we filter the daps accordingly.

Changes

  • Extract dapps filter function.
  • Add filter by hidden dApps from the User Profile.

Tests

Tests provided.

@AntonioVentilii AntonioVentilii marked this pull request as ready for review December 3, 2024 22:54
@AntonioVentilii AntonioVentilii requested a review from a team as a code owner December 3, 2024 22:54
@AntonioVentilii AntonioVentilii marked this pull request as draft December 5, 2024 15:44
@AntonioVentilii AntonioVentilii marked this pull request as ready for review December 5, 2024 16:58
@AntonioVentilii
Copy link
Collaborator Author

@peterpeterparker ready for another review, but have a look, I changed a bit, according to recent PRs

@AntonioVentilii AntonioVentilii removed the request for review from DenysKarmazynDFINITY December 5, 2024 21:01
Copy link
Member

@peterpeterparker peterpeterparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx

@AntonioVentilii AntonioVentilii enabled auto-merge (squash) December 6, 2024 07:24
@AntonioVentilii AntonioVentilii merged commit ab390e3 into main Dec 6, 2024
18 checks passed
@AntonioVentilii AntonioVentilii deleted the feat(frontend)/filter-carousel-dApps-using-user-profile branch December 6, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants