-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(e2e): added conditial device usage #3886
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….com/dfinity/oisy-wallet into fix(e2e)/include-devices-based-on-os
….com/dfinity/oisy-wallet into fix(e2e)/include-devices-based-on-os
AntonioVentilii
added a commit
that referenced
this pull request
Jan 6, 2025
# Motivation Splitting #3886 , we first define the MATRIX_OS environment variable for each E2E os. --------- Co-authored-by: Nico Mächler <[email protected]> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
…nity/oisy-wallet into fix(e2e)/include-devices-based-on-os
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want to ensure that macOS runners are ONLY used for Apple devices and that everything else is being tested on ubuntu runners.
Changes
adjusted the configuration for handling conditional device usage based on os.