Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): add loader for solana balances #4021

Closed
wants to merge 21 commits into from

Conversation

loki344
Copy link
Collaborator

@loki344 loki344 commented Dec 18, 2024

Motivation

Implement solana balance service.

Changes

  • implement solana balance service

Tests

Unit testing added for solana balance service

@loki344 loki344 marked this pull request as ready for review December 18, 2024 14:58
@loki344 loki344 requested a review from a team as a code owner December 18, 2024 14:58
Copy link
Member

@peterpeterparker peterpeterparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please split the solution in separate PRs. The logic and UI presentation can be decoupled.

@loki344
Copy link
Collaborator Author

loki344 commented Dec 18, 2024

Please split the solution in separate PRs. The logic and UI presentation can be decoupled.

moved UI logic to: #4022

@loki344 loki344 marked this pull request as draft December 18, 2024 22:25
@loki344
Copy link
Collaborator Author

loki344 commented Dec 18, 2024

Converted to draft - not rdy yet

@loki344
Copy link
Collaborator Author

loki344 commented Dec 19, 2024

incorporated this branch in #4037, will close it

@loki344 loki344 closed this Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants