Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(frontend): Display the fee types in the Swap modal in the correct format #4660

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(frontend): Display the fee types in the Swap modal in the correct format #4660

wants to merge 2 commits into from

Conversation

DecentAgeCoder
Copy link
Collaborator

Motivation

The fees in the Swap UI are currently displayed in the scientific format.

Changes

  • Introduced a new function which mainly formats a given token amount to a String
  • Introduced an additional reactive variable for the formatted token amount for each fee type

Tests

Screenshot from 2025-02-10 16-47-49
Screenshot from 2025-02-10 16-47-13

@DecentAgeCoder DecentAgeCoder requested a review from a team as a code owner February 10, 2025 15:59
@DenysKarmazynDFINITY DenysKarmazynDFINITY force-pushed the fix(frontend)/fix-incorrect-format-for-token-fee branch from 1e00dfe to f3febc6 Compare February 12, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AntonioVentilii AntonioVentilii AntonioVentilii left review comments

@DenysKarmazynDFINITY DenysKarmazynDFINITY Awaiting requested review from DenysKarmazynDFINITY

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DecentAgeCoder @AntonioVentilii @DenysKarmazynDFINITY