feat(frontend): New bottom main navigation for mobile #4955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at(frontend)/mobile-bottom-navigation-bar
…igation-bar' into feat(frontend)/mobile-bottom-navigation-bar
…igation-bar' into feat(frontend)/mobile-bottom-navigation-bar
AntonioVentilii
requested changes
Mar 5, 2025
AntonioVentilii
requested changes
Mar 5, 2025
There was a problem hiding this comment.
for example, this one is a bit strange... can it be that we screenshot even what's beyond the newport (the entire scrollable screen)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
It has been decided by the design team that the mobile version of the wallet needs a dedicated navigation bar.
Here we add a bottom navbar and adjust some aspects of the app to accommodate that change.
Changes
mdbg-primary-inverted-altwhich is used for bottom nav bgTests