Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): enables send form usd value #4965

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

BonomoAlessandro
Copy link
Collaborator

@BonomoAlessandro BonomoAlessandro commented Feb 28, 2025

Motivation

It should be possible to choose between token amount and USD amount while entering the balance to send.

Tests

oisy-wallet-send-usd-value.mp4

@BonomoAlessandro BonomoAlessandro marked this pull request as ready for review February 28, 2025 12:50
@BonomoAlessandro BonomoAlessandro requested a review from a team as a code owner February 28, 2025 12:50
@@ -39,7 +39,7 @@
<button
class:hover:cursor-default={disabled}
{disabled}
on:click={handleUnitSwitch}
on:click|preventDefault={handleUnitSwitch}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this one needed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AntonioVentilii Yes, otherwise if the form is filled out and you press the swap currency button you will get directed to the review page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants