feat(frontend): include nICP token #5050
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Motivation We want to include the nICP token. ``` Ledger Canister: buwm7-7yaaa-aaaar-qagva-cai Index Canister: btxkl-saaaa-aaaar-qagvq-cai ``` (see https://docs.waterneuron.fi/more/canisters)
# Motivation This PR prepares the release of version v1.2.1. It is a patch to include `nICP` token.
AntonioVentilii
requested review from
DenysKarmazynDFINITY,
Copilot,
StefanBerger-DFINITY and
peterpeterparker
There was a problem hiding this comment.
PR Overview
This PR adds support for the new nICP token to the frontend environment.
- Introduces a new constant (nICP_IC_DATA) that wraps the nICP token configuration.
- Updates the ICRC_TOKENS array to include the nICP token alongside existing tokens.
Reviewed Changes
| File | Description |
|---|---|
| src/frontend/src/env/networks/networks.icrc.env.ts | Added nICP_IC_DATA declaration and updated token list to include nICP |
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
src/frontend/src/env/networks/networks.icrc.env.ts:430
- Verify that the hardcoded position '17' is appropriate for the new nICP token configuration and does not conflict with other token setups.
position: 17
src/frontend/src/env/networks/networks.icrc.env.ts:504
- Ensure that the addition of the nICP token is verified through adequate tests in the token integration test suite.
...(nonNullish(nICP_IC_DATA) ? [nICP_IC_DATA] : [])
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The commits in this branch were already reviewed and are used for the patch released with
v1.2.1Reviews: