feat(frontend): reduce the number of calls of the Solana wallet #5060
+12
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Overview
This PR reduces the Solana wallet RPC calls by increasing the delay interval to one minute, which helps reduce costs associated with RPC calls.
- Introduces a new constant SOL_WALLET_TIMER_INTERVAL_MILLIS set to one minute.
- Updates the Solana wallet scheduler and its test spec to use the new timer interval.
Reviewed Changes
| File | Description |
|---|---|
| src/frontend/src/lib/constants/app.constants.ts | Adds a new constant to delay Solana wallet RPC calls. |
| src/frontend/src/sol/schedulers/sol-wallet.scheduler.ts | Switches the scheduler to use the new Solana wallet timer interval. |
| src/frontend/src/tests/sol/schedulers/sol-wallet.scheduler.spec.ts | Modifies tests to reflect the updated timer interval for Solana wallets. |
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
…-the-Solana-wallet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We pay the calls of the Solana RPC provider, and they are proportional to the number. It is becoming too unscalable.
So, as a temporary measure, we delay the calls of the Solana wallet scheduler to one minute (double the other wallets).
Future improvement
This solution should be removed when we have a better one. For example, if we have a Solana RPC canister (similar to the EVM one), or when we change the code to not re-load the same transactions twice but guarantee that the data are correct.