feat(frontend): calculate cumulative balances when parsing Solana transactions #5062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-when-parsing-Solana-transactions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The redeemed SOL value of a Solana
closeAccounttransaction is not explicitly indicated in the transaction data. So it must be inferred/calculated from the latest SOL balance of the ATA that is being closed.After PR #5056 , we can provide the accumulated balances to the mapper.
To calculate them we keep a record in the
reducefunction: every instruction inside a generic transaction will affect the cumulative SOL balance of each address.It is guaranteed to be progressive since the RPC returns the list of instructions in the correct internal chronological order.
The redeemed SOL value is the latest total SOL balance of the closed Associated Token Account.
NOTE: We include WSOL in the calculation, because it is used to affect the SOL balance of the ATA.
Changes
Tests
Apart from expanding the current tests, we verified with a practical transaction comparing our results with Solscan.