Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(guards): Prevent the patron from being the vendor #25

Merged
merged 3 commits into from
Oct 1, 2024
Merged

fix(guards): Prevent the patron from being the vendor #25

merged 3 commits into from
Oct 1, 2024

Conversation

bitdivine
Copy link
Member

@bitdivine bitdivine commented Oct 1, 2024 •
edited
Loading

Motivation

If the caller specifies the vendor as a patron, there is room for attacks.

Changes

  • Return an error if the patron is set as the vendor.

Tests

  • pocket_ic tests are included.

@bitdivine bitdivine marked this pull request as ready for review October 1, 2024 08:32
@bitdivine bitdivine enabled auto-merge (squash) October 1, 2024 08:33
@bitdivine bitdivine merged commit 9059fc8 into main Oct 1, 2024
11 checks passed
@bitdivine bitdivine deleted the api branch October 1, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bitdivine