test PR #381
Draft
test PR #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dskloetd
added a commit
that referenced
this pull request
Jul 22, 2024
# Motivation In #368 I changed to an earlier version of `EndBug/add-and-commit` to avoid having to pass `ref` to the `checkout` action depending on whether the run if for a PR to avoid having to have 4 different checkout steps. I realized that I only need to pass the token if I plan to make changes, so I can combine the checkout steps and still only have 2 while also using newer versions of `actions/checkout` and `EndBug/add-and-commit`. # Changes 1. Check whether commits can be added based on both the presence of the PAT token and the even being for a PR. 2. Use `actions/checkout@v4` and `EndBug/[email protected]`. # Tested [PR](#381) from a forked repo: * Without formatting changes required: https://github.com/dfinity/snsdemo/actions/runs/10040798640/job/27747555323?pr=381 * With formatting changes required: https://github.com/dfinity/snsdemo/actions/runs/10040830499/job/27747653098?pr=381 From this PR: * Without formatting changes required: https://github.com/dfinity/snsdemo/actions/runs/10040798640/job/27747555323?pr=380 * With formatting changes required: https://github.com/dfinity/snsdemo/actions/runs/10040829788/job/27747650644 * Automatic follow-up after commit: https://github.com/dfinity/snsdemo/actions/runs/10040837356/job/27747673570?pr=380 --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing #380