Add missing parameter aliases to align with caller/callee #1522
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue where none of 'HeaderRow', 'TopRow' and 'StartRow' work in ConvertFrom-ExcelToSQLInsert, preventing you from skipping rows.
Issue is that aliases are missing from the parameter list of ConvertFrom-ExcelData.
ConvertFrom-ExcelToSQLInsert accepts 'HeaderRow', 'TopRow' and 'StartRow', but passes 'StartRow', while ConvertFrom-ExcelData only accepts 'HeaderRow'
FIX: Alter ConvertFrom-ExcelData to have the same aliases for the parameter as both its caller, ConvertFrom-ExcelToSQLInsert and its callee, Import-Excel. All three now have:
[Alias('HeaderRow', 'TopRow')]
[Int]$StartRow = 1,