Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Import-Excel] Performance optimization #1602

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

edwardmiller-mesirow
Copy link
Contributor

This reduces redundant lookups on a per-cell basis.

@dfinke dfinke self-assigned this May 18, 2024
@dfinke
Copy link
Owner

dfinke commented May 18, 2024

Thanks, good optimiaztion, need to look at it. Need to look at the tests around it.

There is a mega perf issue I introduced when I added slick feature 'Import-Excel sales.xlsx *.
It reads all the sheets and returns a hashtable keys are the sheet names and values are the data in the sheet.

Unfortunately how I implemented it if you are reading a large sheet, lots of columns and rows, it can go from 20 seconds to minutes. You can search the issues for when it was implemented. Folks pulled the prev version.

If you are so inclined

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants