Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #252 Case insensitive login #306

Open
wants to merge 19 commits into
base: develop
Choose a base branch
from
Open

Conversation

c8y3
Copy link
Contributor

@c8y3 c8y3 commented Sep 6, 2023

This is a proposition to enable case insensitive login as described in issue #252.
This change does not require any database migration, since only the retrieval of a user by its login has change. It is now done with a case insensitive query (ilike)
However this change assumes no two users were, in a previous version of DFIR-IRIS, created with logins which are the same when compared in a case insensitive way (for instance whitekernel and WhiteKernel)
Maybe, in addition to these changes, a script which checks this is the case, should be proposed in the migration note...

@c8y3
Copy link
Contributor Author

c8y3 commented Sep 6, 2023

This is a bit raw, but here is the rough idea for a script which would warn when the database does not satisfy the expectation about login being case-insensitive unique:

from sqlalchemy import create_engine
from sqlalchemy import text


engine = create_engine('postgresql+psycopg2://postgres:[email protected]:5432/iris_db', echo=True)


warnings = {}
with engine.connect() as conn:
# careful the quotes matter here!!!
    result = conn.execute(text('select * from "user"'))
    for row in result:
        login = row.user.lower()
        result = conn.execute(text('select * from "user" where lower("user")=:user'), user=login)
        if result.rowcount != 1:
            warnings[login] = result.all()

for (lower_case_login, users) in warnings.items():
    count = len(users)
    print(f'WARNING: there at least {count} users with logins which are case sensitive equal to \'{lower_case_login}\':')
    for user in users:
       print(f'id: {user.id}, user: {user.user}, name: {user.name}')

@whikernel whikernel changed the base branch from master to develop December 27, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants