Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rest improvement assets #562

Merged
merged 23 commits into from
Aug 12, 2024
Merged

Rest improvement assets #562

merged 23 commits into from
Aug 12, 2024

Conversation

c8y3
Copy link
Contributor

@c8y3 c8y3 commented Aug 7, 2024

Closes #556.

@c8y3 c8y3 added enhancement New feature or request quality labels Aug 7, 2024
@c8y3 c8y3 linked an issue Aug 7, 2024 that may be closed by this pull request
[FR] REST API v2.1.0 first assets endpoints #556
Closed
@c8y3
Copy link
Contributor Author

c8y3 commented Aug 7, 2024

Note to discuss: the return value on 404 is generic and has not the format decided for errors in REST.

Elise17 and others added 22 commits August 9, 2024 17:05
@Elise17 @c8y3
[ADD] New rest endpoint POST /api/v2/cases/<int:caseid>/assets
baaafc2
@Elise17 @c8y3
[FIX] Fix problem on case_assets_routes.py
a25e0a5
@Elise17 @c8y3
[ADD] New rest endpoint GET /api/v2/assets/<int:cur_id>
4e2e29f
@Elise17 @c8y3
[ADD] New rest endpoint DELETE /api/v2/assets/<int:cur_id>
df300e6
@Elise17 @c8y3
[IMP] Change URL name for POST and DELETE /api/v2/assets/asset_id
4e3805e
@Elise17 @c8y3
[IMP] Moved code to create an assets down into the business layer
f4adb0f
@Elise17 @c8y3
[IMP] rename update, delete, create to tasks_update, tasks_create and…
180a2c7 
… tasks_delete
@Elise17 @c8y3
[FIX] Fix problem on renamed tasks actions
63c3582
@Elise17 @c8y3
[IMP] Using task_delete for /api/v2/tasks/task_id
7d282ee
@Elise17 @c8y3
[IMP] Using tasks_create for /api/v2/caes/caseid/tasks
e6bc896
@Elise17 @c8y3
[IMP] Using task_create and task_delete in case_task_routes.py
8af4ada
@Elise17 @c8y3
[IMP] Start the name of old URL function name with deprecated_ in cas…
c2ad55a 
…e_task_routes.py
@Elise17 @c8y3
[IMP] Start the name of old URL function name with deprecated_ in cas…
63fb116 
…e_ioc_routes.py
@Elise17 @c8y3
[IMP] Changed some code to delete an assets in case_assets_routes
3a40a97
@Elise17 @c8y3
[ADD] Add test_delete_asset_should_return_204 and test_delete_asset_w…
d3ecec9 
…ith_missing_asset_identifier_should_return_404
@Elise17 @c8y3
[ADD]Changed some code to add an asset in case_assets_routes and in t…
1c46e57 
…est_rest
@Elise17 @c8y3
[IMP] Change data to textStatus in case.asset.js
2f11c6c
@Elise17 @c8y3
[IMP] Replaced response_succes and response_error to response_api_err…
a41b6bd 
…or, response_api_created
@Elise17 @c8y3
[IMP] Change name of function case_view_ioc
c7e98ff
@Elise17 @c8y3
[ADD] Add function get_asset() in assets.py
245a4b8
@Elise17 @c8y3
[IMP] Improved test_get_asset_with_missing_asset_identifier_should_re…
a5dcc78 
…turn_404
@Elise17 @c8y3
[IMP] Changed name test_get_asset_with_missing_asset_identifier_shoul…
aa0ddd5 
…d_return_404
@whikernel
Copy link
Contributor

will resolve the import issue after merge

@whikernel whikernel merged commit c74fdbc into develop Aug 12, 2024
4 of 6 checks passed
@c8y3 c8y3 deleted the rest_improvement_assets branch August 14, 2024 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FR] REST API v2.1.0 first assets endpoints
3 participants
@c8y3 @whikernel @Elise17