Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More fine tuning #614

Merged
merged 46 commits into from
Oct 14, 2024
Merged

More fine tuning #614

merged 46 commits into from
Oct 14, 2024

Conversation

c8y3
Copy link
Contributor

@c8y3 c8y3 commented Oct 11, 2024

  • endpoint GET /api/v2/cases, changed field cases into data, so that endpoints which return paginated lists are standardized
  • endpoint GET /api/v2/cases/{identifier}/iocs, changed field iocs into data, so that endpoints which return paginated lists are standardized
  • return 404 when trying to delete inexistant task
  • return 404 when trying to delete inexistant IOC
  • return 404 when trying to delete inexistant asset
  • return 404 when trying to create an asset in an inexistant case
  • moved code out of utils.py into the blueprints namespace (in access_controls.py and responses.py)
  • some cleanups: removed some seemingly dead methods, marked some methods as private (underscore prefix), simple quotes vs. double quotes

c8y3 added 30 commits October 9, 2024 08:30
@c8y3 c8y3 added the quality label Oct 11, 2024
@c8y3 c8y3 requested a review from whikernel October 11, 2024 06:15
@whikernel whikernel merged commit 8ca28ba into develop Oct 14, 2024
6 checks passed
@c8y3 c8y3 deleted the api_v2_get_cases branch October 15, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants