Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanthat #11

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Conversation

cleanthat[bot]
Copy link
Contributor

@cleanthat cleanthat bot commented Jul 30, 2023

CleanThat is willing to clean a protected branch.

@solven-eu/cleanthat-notify please look at me

dgmjr and others added 13 commits June 30, 2023 01:23
- Update default solution path in VSCode settings
- Add new icon file in the Assets folder
- Update build configurations for staging and release
- Update development dependencies targets
- Update global usings in project files
- Update NuGetizer and PackageIcon targets
- Update package readme contents
- Update package version override behavior
- Added PackageIcon property with value "Icon.png" to the PropertyGroup in DgmjrSdk.nuproj file.

UPDATED: Added missing IsMultitargeting.props file.

- Created IsMultitargeting.props file with creation and modification timestamps.
- Added author and copyright information.
- The file is licensed under the MIT license.
- Renamed DgmjrSdk.nupro  - Added ProjectGuid and ProjectTypeGuid tags
  - Commented out Target tag
- ModifiedgmjrSdk.csproj
- Renamed "DgmjrSdk.csproj" to "DjrSdk.nuproj".
- Added new package files to include in the build: "*.props" and "*.targets".
….NET versions.

ADDED: Added default values generating XML documentation and pulling XML docs from referenced packages.

ADDED: Added all `Include[Whatever]OutputGroup` properties set to `true`.

FIXED: Fixed the condition for `PackageIconFile` in `PackageIcon.targets` to ensure it copies the correct icon file.

UPDATED: Updated the `NeutralLanguage` property in `ProjectMetadata.props `en-US` to `en`.

UPDATED: Updated the default `AssemblyTitle` property in `ProjectMetadata.props` to use the `MSBuildProjectName`.

AD: Added assembly signingjr.sn inAssets` folder.

ADDED: Added the `TestingLocal` configuration, which overrides the `AssemblyVersion` attribute to `0.0.1-Local`.

ADDED: Added a default icon file `Icon.png`, which will be used for packages that don't have an icon.
nb_files_neither_included_nor_excluded: 8
nb_files_formatted: 1
eventKey: random-eedbec93-7543-42c8-8a78-857e2138391d
@dgmjr dgmjr marked this pull request as ready for review August 13, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant