-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanthat #11
Open
cleanthat
wants to merge
13
commits into
main
Choose a base branch
from
cleanthat/headfor-refs_heads_main-2023-07-30
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Cleanthat #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update default solution path in VSCode settings - Add new icon file in the Assets folder - Update build configurations for staging and release - Update development dependencies targets - Update global usings in project files - Update NuGetizer and PackageIcon targets - Update package readme contents - Update package version override behavior
- Added PackageIcon property with value "Icon.png" to the PropertyGroup in DgmjrSdk.nuproj file. UPDATED: Added missing IsMultitargeting.props file. - Created IsMultitargeting.props file with creation and modification timestamps. - Added author and copyright information. - The file is licensed under the MIT license.
- Renamed DgmjrSdk.nupro - Added ProjectGuid and ProjectTypeGuid tags - Commented out Target tag - ModifiedgmjrSdk.csproj
…g and uvlong, moved setpackagemetadata
- Renamed "DgmjrSdk.csproj" to "DjrSdk.nuproj". - Added new package files to include in the build: "*.props" and "*.targets".
….NET versions. ADDED: Added default values generating XML documentation and pulling XML docs from referenced packages. ADDED: Added all `Include[Whatever]OutputGroup` properties set to `true`. FIXED: Fixed the condition for `PackageIconFile` in `PackageIcon.targets` to ensure it copies the correct icon file. UPDATED: Updated the `NeutralLanguage` property in `ProjectMetadata.props `en-US` to `en`. UPDATED: Updated the default `AssemblyTitle` property in `ProjectMetadata.props` to use the `MSBuildProjectName`. AD: Added assembly signingjr.sn inAssets` folder. ADDED: Added the `TestingLocal` configuration, which overrides the `AssemblyVersion` attribute to `0.0.1-Local`. ADDED: Added a default icon file `Icon.png`, which will be used for packages that don't have an icon.
nb_files_neither_included_nor_excluded: 8 nb_files_formatted: 1 eventKey: random-eedbec93-7543-42c8-8a78-857e2138391d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CleanThat is willing to clean a protected branch.
@solven-eu/cleanthat-notify please look at me