Create an optimization function which processes the graph and convert… #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s into a single python function eliminating all recursion and discovery.
|
Very cool. Looks useful to me though I no longer have the bandwidth to actively review and test pycel contributions in detail. |
|
Looks very cool @tarkmeper - was wondering if you ever got this working end-to-end, would love to try it out! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request isn't in any way ready for merging but is more of an idea I'd like to get feedback on and if this is something you'd consider for inclusion in Pycel before putting in more effort to get it into that shape.
The code creates an optimized version of the logic based on the desired inputs/outputs. It traverses the graph and merges all the python_code text into a single function that is dynamically created and returned. Very simple functions can also be optimized with Numba to allow for compiler optimizations.
On my computer on a simple test case:
* Calling "evaluate" directly on outputs took 11.14 seconds
* Using non-Numba optimized version took 29ms (381x speed-up)
* Using numba optimized version took 0.5 ms (2228x speed-up)
Todos:
* Some code clean-up and comment cleanup
* Import remaining functions - only sin/sum currently will work.
* Loads more testing
* Better API for generated function currently takes and returns tuples in order to allow numba support.