Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downstream/feature GitHub workflow build compare #81

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 23 additions & 17 deletions .github/workflows/_backstop-docker-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,10 @@ run-name: "CI running on ${{ github.event_name == 'pull_request' && format('PR #

on:
workflow_dispatch:
# pull_request:
# branches: [master, develop]
pull_request:
branches: [master, develop]
push:
branches: [master, develop]

permissions:
checks: write
Expand All @@ -16,7 +18,7 @@ permissions:
packages: write

env:
BRANCH_NAME: ${{ github.head_ref || github.ref_name }}
BRANCH_NAME: ${{ github.event.pull_request.head.sha || github.head_ref || github.ref_name }}

jobs:
backstop-sanity-test:
Expand All @@ -27,20 +29,24 @@ jobs:
name: Smoke Test Backstop
uses: ./.github/workflows/backstop-smoke-test.yml

backstop-integration-test:
name: Integration Test Backstop
uses: ./.github/workflows/backstop-integration-test.yml
# backstop-integration-test:
# name: Integration Test Backstop
# uses: ./.github/workflows/backstop-integration-test.yml

build-publish-docker:
name: Build Docker
uses: ./.github/workflows/docker-build.yml
# build-publish-docker:
# name: Build Docker
# uses: ./.github/workflows/docker-build.yml

docker-sanity-test:
needs: build-publish-docker
name: Sanity Test Docker
uses: ./.github/workflows/docker-sanity-test.yml
# docker-sanity-test:
# needs: build-publish-docker
# name: Sanity Test Docker
# uses: ./.github/workflows/docker-sanity-test.yml

docker-smoke-test:
needs: build-publish-docker
name: Smoke Test Docker
uses: ./.github/workflows/docker-smoke-test.yml
# docker-smoke-test:
# needs: build-publish-docker
# name: Smoke Test Docker
# uses: ./.github/workflows/docker-smoke-test.yml

# build-compare:
# name: Build Compare UI
# uses: ./.github/workflows/build-compare.yml
4 changes: 2 additions & 2 deletions .github/workflows/backstop-integration-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ jobs:
- name: Checkout
uses: actions/checkout@v4
with:
fetch-depth: 0
ref: ${{ github.event.pull_request.head.ref || github.ref }}
fetch-depth: 1
ref: ${{ github.event.pull_request.head.sha || github.ref }}

- name: ⬢ Setup Node & Cache
uses: actions/setup-node@v4
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/backstop-sanity-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ jobs:
- name: Checkout
uses: actions/checkout@v4
with:
fetch-depth: 0
ref: ${{ github.event.pull_request.head.ref || github.ref }}
fetch-depth: 1
ref: ${{ github.event.pull_request.head.sha || github.ref }}

- name: ⬢ Setup Node & Cache
uses: actions/setup-node@v4
Expand All @@ -42,8 +42,8 @@ jobs:
- name: Checkout
uses: actions/checkout@v4
with:
fetch-depth: 0
ref: ${{ github.event.pull_request.head.ref || github.ref }}
fetch-depth: 1
ref: ${{ github.event.pull_request.head.sha || github.ref }}

- name: ⬢ Setup Node & Cache
uses: actions/setup-node@v4
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/backstop-smoke-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ jobs:
- name: Checkout
uses: actions/checkout@v4
with:
fetch-depth: 0
ref: ${{ github.event.pull_request.head.ref || github.ref }}
fetch-depth: 1
ref: ${{ github.event.pull_request.head.sha || github.ref }}

- name: ⬢ Setup Node & Cache
uses: actions/setup-node@v4
Expand All @@ -43,8 +43,8 @@ jobs:
- name: Checkout
uses: actions/checkout@v4
with:
fetch-depth: 0
ref: ${{ github.event.pull_request.head.ref || github.ref }}
fetch-depth: 1
ref: ${{ github.event.pull_request.head.sha || github.ref }}

- name: ⬢ Setup Node & Cache
uses: actions/setup-node@v4
Expand Down
36 changes: 36 additions & 0 deletions .github/workflows/build-compare.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
name: Build Compare Test

on:
workflow_dispatch:
workflow_call:

permissions:
contents: write
pull-requests: write

env:
NODE_VERSION: 20

jobs:
build-compare:
name: 🚜 Build Compare
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v4
with:
fetch-depth: 1
ref: ${{ github.event.pull_request.head.sha || github.ref }}

- name: ⬢ Setup Node & Cache
uses: actions/setup-node@v4
with:
cache: "npm"
cache-dependency-path: package-lock.json

- name: ↧ Install
run: npm ci

- name: "Run `npm run build-compare`"
run: |
npm run build-compare
6 changes: 3 additions & 3 deletions .github/workflows/docker-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ permissions:
packages: write

env:
BRANCH_NAME: ${{ github.event.pull_request.head_ref || github.event.pull_request.head.ref_name || github.head_ref || github.ref_name }}
BRANCH_NAME: ${{ github.event.pull_request.head_ref || github.event.pull_request.head.sha_name || github.head_ref || github.ref_name }}
NODE_VERSION: 20
REGISTRY: ghcr.io
IMAGE_NAME: ${{ github.repository }}
Expand All @@ -25,8 +25,8 @@ jobs:
- name: Checkout
uses: actions/checkout@v4
with:
fetch-depth: 0
ref: ${{ github.event.pull_request.head.ref || github.ref }}
fetch-depth: 1
ref: ${{ github.event.pull_request.head.sha || github.ref }}

- name: Set Name and Tag Vars
env:
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/docker-sanity-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ permissions:
packages: write

env:
BRANCH_NAME: ${{ github.event.pull_request.head_ref || github.event.pull_request.head.ref_name || github.head_ref || github.ref_name }}
BRANCH_NAME: ${{ github.event.pull_request.head_ref || github.event.pull_request.head.sha_name || github.head_ref || github.ref_name }}
NODE_VERSION: 20
REGISTRY: ghcr.io
IMAGE_NAME: ${{ github.repository }}
Expand All @@ -29,8 +29,8 @@ jobs:
- name: Checkout
uses: actions/checkout@v4
with:
fetch-depth: 0
ref: ${{ github.event.pull_request.head.ref || github.ref }}
fetch-depth: 1
ref: ${{ github.event.pull_request.head.sha || github.ref }}

- name: Set Name and Tag Vars
env:
Expand Down Expand Up @@ -77,8 +77,8 @@ jobs:
- name: Checkout
uses: actions/checkout@v4
with:
fetch-depth: 0
ref: ${{ github.event.pull_request.head.ref || github.ref }}
fetch-depth: 1
ref: ${{ github.event.pull_request.head.sha || github.ref }}

- name: Set Name and Tag Vars
env:
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/docker-smoke-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ permissions:
packages: write

env:
BRANCH_NAME: ${{ github.event.pull_request.head_ref || github.event.pull_request.head.ref_name || github.head_ref || github.ref_name }}
BRANCH_NAME: ${{ github.event.pull_request.head_ref || github.event.pull_request.head.sha_name || github.head_ref || github.ref_name }}
NODE_VERSION: 20
REGISTRY: ghcr.io
IMAGE_NAME: ${{ github.repository }}
Expand All @@ -29,8 +29,8 @@ jobs:
- name: Checkout
uses: actions/checkout@v4
with:
fetch-depth: 0
ref: ${{ github.event.pull_request.head.ref || github.ref }}
fetch-depth: 1
ref: ${{ github.event.pull_request.head.sha || github.ref }}

- name: Set Name and Tag Vars
env:
Expand Down Expand Up @@ -77,8 +77,8 @@ jobs:
- name: Checkout
uses: actions/checkout@v4
with:
fetch-depth: 0
ref: ${{ github.event.pull_request.head.ref || github.ref }}
fetch-depth: 1
ref: ${{ github.event.pull_request.head.sha || github.ref }}

- name: Set Name and Tag Vars
env:
Expand Down
57 changes: 25 additions & 32 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,11 @@

![I'm in your webapps -- checkin your screens](http://garris.github.io/BackstopJS/assets/memes/im-in-ur-webapps-checking-ur-screens.jpg)

**BackstopJS automates visual regression testing of your responsive web UI by comparing DOM screenshots over time.**
**BackstopJS automates visual regression testing of your webapp – comparing screenshots over time.**

## News

**Backstop 6.0.1 -- now with Playwright engine!** Many thanks to our friend @FrostyShosty who came out of nowhere and made it happen!
**Backstop 6.3.2 -- now with support for Node 20** Many thanks to @dgrebb for this doozy of a maintainance release!

**EmberJS users** -- check out our ember-backstop test helper! https://github.com/garris/ember-backstop

Expand Down Expand Up @@ -1172,33 +1172,26 @@ Be sure to use a config `id` in your config file. See https://github.com/garris/

## Credits

BackstopJS was created and is maintained by [Garris Shipon](https://www.linkedin.com/in/garrisshipon/)

<strong><a href="https://twitter.com/garris" class="twitter-follow-button" data-show-count="false">Follow @garris</a></strong>

💙㊗️🙇 Many many thanks to [all the contributors](https://github.com/garris/BackstopJS/graphs/contributors) with special thanks to our BackstopJS core contributors...

- [Brendon Barreto](https://github.com/brendonbarreto) Massive code optimizations and house cleaning in 3.8.5.
- [Gabe Gorelick](https://github.com/gabegorelick) tons of fixes and improvements with error handling and docker integrartion in v3.8.
- [SengitU](https://github.com/SengitU) adding Scenario Specific Viewports in v3.5.9.
- [Walmyr Filho](https://github.com/wlsf82) for awesome articles and [backstop-config](https://github.com/wlsf82/backstop-config).
- [Benjamin Blackwood](https://github.com/BBlackwo) documentation improvements for our win-based brothers and sisters plus fixing a massive bug with our --docker implementation,
[Justin Heideman](https://github.com/justinph) better web-client report UI performance in version 3.5.3.
- [Peter Krautzberger](https://github.com/pkra) improved error handling, [Vladislav Altanov](https://github.com/cactusabg) and [thumpmaster](https://github.com/thumpmaster) improving our screen capture compatibility, [Mikkel Rom Engholm](https://github.com/mikkelrom) improvements to our scrubber modal, [Xingxin Zeng](https://github.com/SBeator) making `expect` config property work, [Andrew Taylor](https://github.com/ataylorme) improvements to report opening -- version 3.2.
- [Christopher Frank](https://github.com/krisdigital) for Puppeteer integration!✨
- [@KenCoder](https://github.com/KenCoder), [@AkA84](https://github.com/AkA84), [@VesterDe](https://github.com/VesterDe), [Vladislav Altanov](https://github.com/cactusa), [Alice Young](https://github.com/aliceyoung9) for documentation, fixes, improved test hygene and support with 3.2 release
- [Gabriele Mantovani](https://github.com/mantovanig) for our beautiful new UI in 3.1.0.
- [Pavel Zbytovský](https://github.com/zbycz), [Đinh Quang Trung](https://github.com/trungdq88), [Dan Pettersson](https://github.com/deap82), [anton-kulagin](https://github.com/anton-kulagin), [Baltazardoung](https://github.com/Baltazardoung), [kiran-redhat](https://github.com/kiran-redhat), [lsuchanek](https://github.com/lsuchanek), [Michal Vyšinský](https://github.com/vysinsky), [Leonid Makarov](https://github.com/lmakarov), [Vladislav Dekov](https://github.com/vdekov) 3.0 post release fixes and features.
- [Shinji Yamada](https://github.com/dotneet) for Chrome Headless & Chromy.JS integration support in 3.0.0.
- [Shane McGraw](https://github.com/shanemcgraw) for testing and awesomeness during 3.0 development.
- [Steve Fischer](https://github.com/stevecfischer), [uğur mirza zeyrek](mirzazeyrek), [Sven Wütherich](svwu), [Alex Bondarev](https://github.com/skip405) for concurrency support, JS config passing, JPEG support, CLI Auth support.
- [Klaus Bayrhammer](https://github.com/klausbayrhammer) for making BackstopJS a "requireable" node module in 2.3.1
- [@JulienPradet](https://github.com/JulienPradet), [@onigoetz](https://github.com/onigoetz), [@borys-rudenko](https://github.com/borys-rudenko), [@ksushik](https://github.com/ksushik), [@dmitriyilchgmailcom](https://github.com/dmitriyilchgmailcom), [@Primajin](https://github.com/Primajin) for giving the world BackstopJS version 2.0!
- [Suresh Kumar. M](https://github.com/nobso) for selector expansion in 1.3.2
- [Klaus Bayrhammer](https://github.com/klausbayrhammer) for all the incredible effort leading up to 1.0 -- the cli reports and compatibility fixes are awesome!
- [Evan Lovely](https://github.com/EvanLovely) and [Klaus Bayrhammer](https://github.com/klausbayrhammer) for help on the 0.9.0 release
- [Robert O'Rourke](https://github.com/sanchothefat) for help on the 0.8.0 release
- [Klaus Bayrhammer](https://github.com/klausbayrhammer) for help on the 0.7.0 release
- [Benedikt Rötsch](https://github.com/axe312ger) for help on the 0.6.0 release
- [Yulia Tsareva](https://github.com/YuliaTsareva) for help on the 0.5.0 release -- windows support
- [Lewis Nyman](https://github.com/lewisnyman) and [Stoutie](https://github.com/jehoshua02) for help with 0.4.0 release -- you guys are responsible for really getting the ball rolling!
BackstopJS was created and is maintained by [Garris Shipon](https://www.linkedin.com/in/garrisshipon/) with help from [these amazing engieers](https://github.com/garris/BackstopJS/graphs/contributors).


🙇 Special thanks to these contributors...
- [Lewis Nyman](https://github.com/lewisnyman)
- [Stoutie](https://github.com/jehoshua02)
- [Klaus Bayrhammer](https://github.com/klausbayrhammer)
- [Evan Lovely](https://github.com/EvanLovely)
- [Benedikt Rötsch](https://github.com/axe312ger)
- [Suresh Kumar. M](https://github.com/nobso)
- [Shinji Yamada](https://github.com/dotneet)
- [@onigoetz](https://github.com/onigoetz)
- [uğur mirza zeyrek](mirzazeyrek)
- [anton-kulagin](https://github.com/anton-kulagin)
- [Leonid Makarov](https://github.com/lmakarov)
- [Gabriele Mantovani](https://github.com/mantovanig)
- [Walmyr Filho](https://github.com/wlsf82)
- [Torsten Krah](https://github.com/tkrah)
- [Joel Brown](https://github.com/FrostyShosty)
- [Dan Grebb](https://github.com/dgrebb)



2 changes: 1 addition & 1 deletion index.html
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ <h1>Visual regression testing for web apps.</h1>
</div>
<div class="row justify-content-center">
<p class="getItBlock col-10">
BackstopJS was created by <a href="https://www.linkedin.com/in/garrisshipon/">Garris Shipon</a> with contributions from <a href="https://github.com/garris/BackstopJS#credits">these amazing engineers</a>.
BackstopJS was created by <a href="https://www.linkedin.com/in/garrisshipon/">Garris Shipon</a> with contributions from <a href="https://github.com/garris/BackstopJS/graphs/contributors">these amazing engineers 💜</a>.
</p>
<p class="getItBlock col-10">
Opensourced under the <a href="https://raw.githubusercontent.com/garris/BackstopJS/master/LICENSE">The MIT License</a>.
Expand Down