Don't send old FCM tokens when new token is generated during startup (#…

…1440) Co-authored-by: Tom Sightler <[email protected]>
dgreif · Jul 23, 2024 · 0d93c93 · 0d93c93
1 parent cd6be9a
commit 0d93c93
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 3 deletions.
diff --git a/.changeset/beige-pianos-double.md b/.changeset/beige-pianos-double.md
@@ -0,0 +1,6 @@
+---
+'homebridge-ring': patch
+'ring-client-api': patch
+---
+
+Handle push-receiver credentials upon first startup after upgrading
diff --git a/packages/ring-client-api/api.ts b/packages/ring-client-api/api.ts
@@ -233,6 +233,7 @@ export class RingApi extends Subscribed {
     intercoms: RingIntercom[],
   ) {
     const credentials =
+        this.restClient._internalOnly_pushNotificationCredentials?.config &&
         this.restClient._internalOnly_pushNotificationCredentials,
       pushReceiver = new PushReceiver({
         firebase: {
@@ -241,7 +242,7 @@ export class RingApi extends Subscribed {
           messagingSenderId: '876313859327', // for Ring android app.  703521446232 for ring-site
           appId: '1:876313859327:android:e10ec6ddb3c81f39',
         },
-        credentials: credentials?.config ? credentials : undefined,
+        credentials,
         debug: false,
       }),
       devicesById: { [id: number]: RingCamera | RingIntercom | undefined } = {},
@@ -358,8 +359,12 @@ export class RingApi extends Subscribed {
       }
     })
 
-    // If we already have credentials, use them immediately
-    if (credentials) {
+    // If we already have credentials and they haven't been changed during registration, use them immediately
+    if (
+      credentials &&
+      credentials?.fcm?.token ===
+        this.restClient._internalOnly_pushNotificationCredentials?.fcm?.token
+    ) {
       onPushNotificationToken.next(credentials.fcm.token)
     }
   }