Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for reading company ticker data from local #138

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Add support for reading company ticker data from local #138

merged 2 commits into from
Nov 7, 2024

Conversation

pierotofy
Copy link
Contributor

This PR adds support for reading company ticker data locally (without needing to ping SEC).

  • Adds support for downloading reference data in download_edgar_data()
  • Adds support for reading the local reference data in get_cik_tickers_from_ticker_txt and get_company_tickers.

@pierotofy
Copy link
Contributor Author

I'm not sure why the Smoke test for recent filings failed, but I'm guessing it's unrelated to this PR as this command runs fine on my machine:

EDGAR_IDENTITY="S Robinson [email protected]" python tests/batch/batch_filings.py -y 2024 -s 40
echo $? --> 0

dgunning
dgunning approved these changes Nov 7, 2024
View reviewed changes
Copy link
Owner

@dgunning dgunning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Approving and will test

@dgunning dgunning merged commit f834639 into dgunning:main Nov 7, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgunning dgunning dgunning approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pierotofy @dgunning