Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added function to find individual company ticker from CIK value #141

Merged
merged 4 commits into from
Nov 3, 2024

Conversation

webbsledge
Copy link
Contributor

Implement simple function to lookup a ticker for a single CIK value. I didn't see this implemented anywhere already.

Copy link
Owner

@dgunning dgunning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably needed so thanks for this.

2 issues - a cik might have more than one ticker - do you intend to return just the first one?

We also need to handle the case when the ticker is not found so that it does not result in an exception

@webbsledge
Copy link
Contributor Author

webbsledge commented Nov 2, 2024

Made some changes to return a list of tickers or a single ticker, depending. Also added some exception handling... hopefully not overkill.

Copy link
Owner

@dgunning dgunning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Will integrate and test

@dgunning dgunning merged commit 90fd1a9 into dgunning:main Nov 3, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants