-
-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support Go on provided.al2 runtime #1691
base: master
Are you sure you want to change the base?
Conversation
This adds support for the current runtime used for Go on AWS. The `go1.x` runtime is EOL as its underlying AMI became EOL on 2020-12-31 and `provided.al2` is its replacement (https://aws.amazon.com/blogs/compute/migrating-aws-lambda-functions-to-al2/). Whilst the AMI is still under extended maintenance support, this extends only until 2023-12-31 (https://aws.amazon.com/blogs/aws/update-on-amazon-linux-ami-end-of-life/). This also ensures that any `vendor/` directories from Go in the runtime tests are ignored.
We need this functionality to run offline using go in the provided.al2 runtime |
Why hasn't this been merged? |
Just an FYI on this: |
any news ????? |
As the go1.x runtime is now officially deprecated and will not get any security updates the new runtimes |
gotta be accepted @dherault |
Hi, this PR haas been open for a long time but still holds value for the community. I'm willing to merge it if someone would fix its conflict and/or re-open it. |
Description
This adds support for the current Go runtime,
provided.al2
, used on AWS Lambda.Motivation and Context
The
go1.x
runtime is EOL as its underlying AMI became EOL on 2020-12-31 andprovided.al2
is its replacement (https://aws.amazon.com/blogs/compute/migrating-aws-lambda-functions-to-al2/). Whilst the AMI is still under technically under extended maintenance support, this extends only until 2023-12-31 (https://aws.amazon.com/blogs/aws/update-on-amazon-linux-ami-end-of-life/).The method here for checking the runtime and the handler's suffix (e.g. its file extension) may appear somewhat brittle but the GoRunner's internals implicitly require the
.go
source to be available and thus the handler already needs to besome/path/function.go
.How Has This Been Tested?
Added integration tests with
provided.al2
runtime and Go handler. Also tested locally in my current project.Screenshots (if appropriate):