fix: Support httpApi authorizer with different config and function names #1763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamldoyle
commented
Feb 27, 2024
| @@ -326,7 +342,7 @@ export default class HttpServer { | |||
| ? serverlessAuthorizerOptions?.payloadVersion || "2.0" | |||
| : "1.0", | |||
| resultTtlInSeconds: | |||
| serverlessAuthorizerOptions?.resultTtlInSeconds || "300", | |||
| serverlessAuthorizerOptions?.resultTtlInSeconds ?? "300", | |||
There was a problem hiding this comment.
Originally I was copying more of the config from serverlessAuthorizerOptions but I un-did that to simplify the logic. However, this needed to be changed in order to allow 0 to be set for resultTtlInSeconds inside the provider config.
|
reopen to run ci |
|
@adamldoyle Looks like |
…ck if httpApi before redirecting auth function
adamldoyle
force-pushed
the
http-api-authorizer-name
branch
from
23048aa to
014b518
Compare
|
@DorianMazur the failing test should be fixed now. |
|
Thank you @adamldoyle |
cnuss
added a commit
to scaffoldly/serverless-offline
that referenced
this pull request
May 27, 2024
* master: fix: Support httpApi authorizer with different config and function names (dherault#1763) fix: Support ALB Event response headers (dherault#1756) v13.6.0 fix: treat application/octet-stream as a binary encoding (dherault#1587) feat: add support for provided.al2023 (dherault#1788) v13.5.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
httpApi authorizer's have their config in the provider section with a name that can be used by httpApi events to attach that authorizer. The authorizer's underlying function is separately defined and is allowed to have a different name than the authorizer config in the provider section. The current implementation by serverless-offline requires that both of those names are the same. This PR fixes this issue by embedding all of the provider config and setting the function name to the one defined in the config.
Motivation and Context
Fixes #1624
How Has This Been Tested?
Manually tested with a small sample app that reproduced the initial issue. Updated existing integration tests that weren't actually using the correct authorizer names (they were using the function names). Added new integration test to reference an authorizer based on config name and have it point to a function name with a different name.
Screenshots (if appropriate):
N/A