Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dantonmod] Resolve issues found by PVS studio #11

Open
demoth opened this issue Jul 20, 2019 · 1 comment
Open

[dantonmod] Resolve issues found by PVS studio #11

demoth opened this issue Jul 20, 2019 · 1 comment

Comments

@demoth
Copy link

demoth commented Jul 20, 2019

Hi guys

This is the report of issues found by static analysis tool PVS studio.
I hope it will be helpful to identify potential and real bugs.
Run over dantonmod branch
https://docs.google.com/spreadsheets/d/1NZSJ1BfDV_ciyK0p6UvnkwAzURwMbdxChrRw4hXNpUQ/edit?usp=sharing

@turol
Copy link
Contributor

turol commented Jul 24, 2019

I took a quick look and at least some of these are false positives caused by the analyzyer not knowing that idGameLocal::Error doesn't return.

Someone should tag that function (and others which don't return like the Error methods called by this function) with some kind of macro which expands to compiler-specific "does not return"-annotation. For GCC that is __attribute__((noreturn)). I have no idea if PVS understands it, someone check the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants