feat: when we have multiple sections, default to first section to avo…

…id performance problems this is a temporary fix untill a proper fix will be in place
dhis2 · Nov 12, 2024 · f60dc2f · f60dc2f
1 parent b5be111
commit f60dc2f
Showing 1 changed file with 2 additions and 5 deletions.
diff --git a/src/context-selection/section-filter-selector-bar-item/section-filter-selector-bar-item.js b/src/context-selection/section-filter-selector-bar-item/section-filter-selector-bar-item.js
@@ -28,8 +28,7 @@ export default function SectionFilterSelectorBarItem() {
 
     useEffect(() => {
         const sections = dataSet?.sections
-        // select first section if renderAsTabs === true
-        if (dataSet?.renderAsTabs && !sectionFilter && sections?.length) {
+        if (sectionFilter === undefined && sections?.length) {
             setSectionFilter(sections[0].id)
         }
         // clear out section if it is invalid
@@ -55,9 +54,7 @@ export default function SectionFilterSelectorBarItem() {
 
     const selectableOptions = dataSet?.renderAsTabs
         ? sectionOptions
-        : [{ value: undefined, label: i18n.t('All sections') }].concat(
-              ...sectionOptions
-          )
+        : [...sectionOptions, { value: null, label: i18n.t('All sections') }]
 
     return (
         <div data-test="section-filter-selector">