fix: prevent unnecessary renders when form has errors #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-358--dhis2-data-entry.netlify.app |
KaiVandivier
approved these changes
Sep 26, 2023
src/data-workspace/entry-form.js
Outdated
Comment on lines
71
to
72
| /* Used to sync store with errors from form | ||
| In its own component to prevent unecessarily re-renders in the tree */ |
There was a problem hiding this comment.
Suggested change
| /* Used to sync store with errors from form | |
| In its own component to prevent unecessarily re-renders in the tree */ | |
| /** | |
| * Used to sync global store with errors from final-form. | |
| * Because of the `errors` subscription in `useFormState`, this re-renders | |
| * on every form input change if there is an error in the form. Therefore, this | |
| * has its own component to prevent unnecessary re-renders below it in the tree | |
| */ |
kabaros
approved these changes
Sep 27, 2023
|
🎉 This PR is included in version 100.3.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #357 , I noticed the entire form was being re-rendered on each input. We've spent quite a lot of time to optimize this, but I realized it only happened when the form contained an error. The culprit was the logic to keep the zustand-store up to date with the form-errors. I've now moved this to its own component, so the hook won't re-render the entire form.
Before:
Screen.Recording.2023-09-26.at.13.33.59.mov
After:
Screen.Recording.2023-09-26.at.13.37.38.mov