chore(report-portal): run reports only when env is setup #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-363--dhis2-data-entry.netlify.app |
adeldhis2
approved these changes
Dec 12, 2023
There was a problem hiding this comment.
LGTM 👍
Thanks Birk for the fix!
I found also this link that could help: How to avoid local execution reported into project space
|
🎉 This PR is included in version 100.3.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After report-portal was added, it was run even if the required environment-variables wasn't configured. This causes a lot of verbose logging and error-messages in the console.
Not sure if this is the best way, but I couldn't find any native way to do this in
agent-js-jest. I'm a bit surprised the tool is actually running even if these variables are not defined.We might want a different
jest.configfor CI and local testing instead?