Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make data entry app support RTL [DHIS2-16779] #409

Merged
merged 2 commits into from
Oct 17, 2024
Merged

Conversation

tomzemp
Copy link
Member

@tomzemp tomzemp commented Oct 17, 2024

This PR updates the data entry app to support RTL display:

  • updated cli-app-scripts, cli-style, and d2-ui dependncies
  • added stylelint for linting
  • ran stylelint and manually fixed some remaining css logical property validations
  • set direction: 'auto' in the d2.config.js
  • did some additional clean up (mostly around specifying arrows based on language)

After:
image

Small issues that I observed:

  • it looks like the UI library needs some adjustments for buttons with icons as the icon is not properly positioned (this is a very minor issue, but is noticeable on the year navigation buttons)
  • some of the displays for mathematical operators, like <, look weird to me, e.g that the text displays as 1y< rather than as <1y. I don't know if this is more logical for an Arabic speaker 🤔. This issue also seems fairly minor to me as it could be addressed by adding a database translation for the category option
  • Not sure if we would want any small adjustments on say number positions given how number input works with Arabic keyboards.

@tomzemp tomzemp requested review from kabaros and a team October 17, 2024 13:08
@dhis2-bot
Copy link
Contributor

🚀 Deployed on https://pr-409--dhis2-data-entry.netlify.app

@dhis2-bot dhis2-bot temporarily deployed to netlify October 17, 2024 13:10 Inactive
@tomzemp tomzemp merged commit d830626 into master Oct 17, 2024
8 checks passed
dhis2-bot added a commit that referenced this pull request Oct 17, 2024
## [100.8.4](v100.8.3...v100.8.4) (2024-10-17)

### Bug Fixes

* make data entry app support RTL [DHIS2-16779] ([#409](#409)) ([d830626](d830626))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 100.8.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants