Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DHIS2-13252): disable install button when no compatible versions are available #543

Merged

Conversation

kabaros
Copy link
Contributor

@kabaros kabaros commented Dec 13, 2023

fixes DHIS2-13252.

This PR fixes an issue where we were still showing the Install button even though there were no compatible versions.

  • I also added some tests since the fix involved some refactoring, and enabled tests on CI
Before After
image image

@kabaros kabaros force-pushed the DHIS2-13252/disable-install-when-no-compatible-versions branch 3 times, most recently from c8b8a3a to 6a45d21 Compare December 13, 2023 11:46
@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

@kabaros kabaros force-pushed the DHIS2-13252/disable-install-when-no-compatible-versions branch from 6a45d21 to cee5a9e Compare December 13, 2023 12:15
@dhis2-bot
Copy link
Contributor

🚀 Deployed on https://pr-543--dhis2-app-management.netlify.app

@dhis2-bot dhis2-bot temporarily deployed to netlify December 13, 2023 12:16 Inactive
@kabaros kabaros marked this pull request as ready for review December 13, 2023 12:36
@kabaros kabaros requested review from a team as code owners December 13, 2023 12:36
Copy link
Member

@Birkbjo Birkbjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM

@kabaros kabaros merged commit b0955db into master Dec 14, 2023
8 checks passed
@kabaros kabaros deleted the DHIS2-13252/disable-install-when-no-compatible-versions branch December 14, 2023 11:40
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 100.2.31 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants