Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DHIS2-15586): update installed state for non-core apps #544

Merged

Conversation

kabaros
Copy link
Contributor

@kabaros kabaros commented Dec 13, 2023

This fixes DHIS2-15586. This is a workaround in the absence of an ID we can rely on, it matches the app with the installed apps using the name + developer email. The chances of these conflicting are low, and I think this is better than the current situation where users can't tell at all if an app was installed or not (check video in Jira ticket).

appmanagement-fix-after

@kabaros kabaros requested review from a team as code owners December 13, 2023 14:44
@dhis2-bot
Copy link
Contributor

dhis2-bot commented Dec 13, 2023

🚀 Deployed on https://pr-544--dhis2-app-management.netlify.app

@dhis2-bot dhis2-bot temporarily deployed to netlify December 13, 2023 14:47 Inactive
@kabaros kabaros force-pushed the DHIS2-15586/update-install-button branch from 1edbf8e to 76152b9 Compare December 13, 2023 15:05
@dhis2-bot dhis2-bot temporarily deployed to netlify December 13, 2023 15:06 Inactive
@kabaros kabaros requested a review from Birkbjo December 13, 2023 15:17
@kabaros kabaros force-pushed the DHIS2-15586/update-install-button branch from 76152b9 to a0ff3c1 Compare December 13, 2023 15:22
@dhis2-bot dhis2-bot temporarily deployed to netlify December 13, 2023 15:24 Inactive
Copy link
Member

@tomzemp tomzemp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me, though I can't get it to run locally (I get a Attempted import error: 'PropTypes' is not exported from '@dhis2/prop-types'., so I guess my @dhis2/prop-types is now not resolving properly?)

I'm also not sure if it was a deliberate choice to include the .nvmrc file?

@kabaros
Copy link
Contributor Author

kabaros commented Dec 14, 2023

Code looks good to me, though I can't get it to run locally (I get a Attempted import error: 'PropTypes' is not exported from '@dhis2/prop-types'., so I guess my @dhis2/prop-types is now not resolving properly?)

I'm also not sure if it was a deliberate choice to include the .nvmrc file?

I think the prop-types is because oyu need to do a yarn install to update the dhis2/ui (which dropped the prop-types export in v9)? I will give it a try again though This was an error caused by ui library bump andwas fixed in base branch

I did add .nvmrc on purpose, since it was not working on newer node versions, and required that one or older specifically

@kabaros kabaros force-pushed the DHIS2-13915/spinner-when-installing branch 5 times, most recently from d2649d8 to f605167 Compare December 14, 2023 14:26
@kabaros kabaros changed the base branch from DHIS2-13915/spinner-when-installing to master December 14, 2023 15:10
@kabaros kabaros force-pushed the DHIS2-15586/update-install-button branch from a0ff3c1 to 7e29c51 Compare December 14, 2023 15:14
@kabaros kabaros changed the base branch from master to DHIS2-13915/spinner-when-installing December 14, 2023 15:15
@dhis2-bot dhis2-bot temporarily deployed to netlify December 14, 2023 15:18 Inactive
@kabaros kabaros merged commit a1e9af8 into DHIS2-13915/spinner-when-installing Dec 14, 2023
10 checks passed
@kabaros kabaros deleted the DHIS2-15586/update-install-button branch December 14, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants