-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [DHIS2-16527] assign user on first stage registration #3530
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @superskip,
I only have a small comment, other than this it looks good. 👏
The Assigned User
label appears larger than the rest. Can its style in Assignee.component.js be adjusted to use the same font size like the other labels in the form?
Thanks!
Well spotted @simonadomnisoru! |
🚀 Deployed on https://deploy-preview-3530--dhis2-capture.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested successfully on 2.41,2.40.4,2.39.5,2.38.7 versions
# [100.57.0](v100.56.0...v100.57.0) (2024-02-19) ### Features * [DHIS2-16527] assign user on first stage registration ([#3530](#3530)) ([54eef90](54eef90))
🎉 This PR is included in version 100.57.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
DHIS2-16527
The code I added in
EnrollmentWithFirstStageDataEntry.component
was copied directly from another file, so not sure what all the properties do and whether some of them could be omitted (please have a look if you recognise them 🙂).