Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [DHIS2-16527] assign user on first stage registration #3530

Merged
merged 4 commits into from
Feb 19, 2024

Conversation

superskip
Copy link
Contributor

@superskip superskip commented Feb 12, 2024

DHIS2-16527

The code I added in EnrollmentWithFirstStageDataEntry.component was copied directly from another file, so not sure what all the properties do and whether some of them could be omitted (please have a look if you recognise them 🙂).

@superskip superskip requested a review from a team as a code owner February 12, 2024 23:25
Copy link
Contributor

@simonadomnisoru simonadomnisoru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @superskip,
I only have a small comment, other than this it looks good. 👏
The Assigned User label appears larger than the rest. Can its style in Assignee.component.js be adjusted to use the same font size like the other labels in the form?

Screenshot 2024-02-13 at 09 55 09

Thanks!

@superskip
Copy link
Contributor Author

Well spotted @simonadomnisoru!
Changed the assignee field label so that it matches the other fields in the enrollment registration form.
These changes makes sense the other place we use this component as well (the single event registration form).

Copy link

Copy link

@geethaalwan geethaalwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested successfully on 2.41,2.40.4,2.39.5,2.38.7 versions

@superskip superskip merged commit 54eef90 into master Feb 19, 2024
37 checks passed
@superskip superskip deleted the DHIS2-16527 branch February 19, 2024 13:55
dhis2-bot added a commit that referenced this pull request Feb 19, 2024
# [100.57.0](v100.56.0...v100.57.0) (2024-02-19)

### Features

* [DHIS2-16527] assign user on first stage registration ([#3530](#3530)) ([54eef90](54eef90))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 100.57.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants