feat: show embedded superset dashboard in iframe #3192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-3192.dashboard.netlify.dhis2.org |
HendrikThePendric
force-pushed
the
feat/show-embedded-superset-dashboard-in-iframe
branch
from
a8eb3b1 to
3558b92
Compare
HendrikThePendric
changed the title
HendrikThePendric
force-pushed
the
feat/show-embedded-superset-dashboard-in-iframe
branch
from
ab13eae to
9825ca7
Compare
|
HendrikThePendric
merged commit 9524153
into
feat/embedded-superset-dashboards-DHIS2-17891
31 checks passed
HendrikThePendric
deleted the
feat/show-embedded-superset-dashboard-in-iframe
branch
HendrikThePendric
added a commit
that referenced
this pull request
Feb 4, 2025
* chore: include embedded field when fetching dashboards * chore: include embedded field when fetching an individual dashboard * fix: ensure embedded property is on the selected dashboard state * feat: show embedded-superset-dashboard and allow it to take up the full page * chore: add @superset/embedded-sdk dependency * chore: add a redux selector that returns the superset embed data * chore: add an api helper that returns a superset guest token * feat: load superset embedded dashboard into DOM * fix: remove whitespace from dashboard container when displaying an embedded dashboard * fix: adjust dashboard-type-radio focus style * chore: set focus with focusVisible to theoretically show the blue focus outline * feat: loading and error state on superset embedded dashboard * fix: add padding to description when dasboard is embedded * chore: fix failing tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I've added support for showing a superset dashboard in the dashboard-app. Some notes:
And this PR also includes a small unrelated change: the dashboard-type-radio now only gets a focus outline when the user starts using keyboard navigation. We are still discussing wether or not this is better than the previous solution, so this may be subject to change later on. I woulnd't pay too much notices to the changes in
src/components/DashboardsBar/CreateDashboardButton/styles/DashboardTypeRadio.module.css