feat: embedded superset dashboards #3205
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-3205.dashboard.netlify.dhis2.org |
* feat: fetch superset base url with system settings * fix: add hook dependencies and ensure fetchSuperSetBaseUrl is a stable reference * feat: add hooks to read global superset data * chore: ensure set in superset is in lower case * chore: adjust request error message
* chore: ignore aider ai files * refactor: extract CreateDashboardButton and NavigationMenuDropdownButton components * fix: read system settings from nested object in hooks * feat: creation flow with conditional support for superset embedded dashboards * chore: remove unused import * feat: add form that can be used for creating and editing superset embedded dashboards * chore: add file extensions to imports * chore: addjust formatting * feat: create superset embedded dashboards * fix: complete hook dependencies * fix: consolidate keyboard navigation implementation across modal forms * fix: adjust modal form, radio card styles * chore: add reminder to add tests for UUID validation * fix: set focus on first fiel in modal form instead of setting focus to fieldset * fix: align radio card outline visibility with other inputs * chore: reorganise files --------- Co-authored-by: Joseph John Aas Cooper <[email protected]>
* chore: include embedded field when fetching dashboards * chore: include embedded field when fetching an individual dashboard * fix: ensure embedded property is on the selected dashboard state * feat: show embedded-superset-dashboard and allow it to take up the full page * chore: add @superset/embedded-sdk dependency * chore: add a redux selector that returns the superset embed data * chore: add an api helper that returns a superset guest token * feat: load superset embedded dashboard into DOM * fix: remove whitespace from dashboard container when displaying an embedded dashboard * fix: adjust dashboard-type-radio focus style * chore: set focus with focusVisible to theoretically show the blue focus outline * feat: loading and error state on superset embedded dashboard * fix: add padding to description when dasboard is embedded * chore: fix failing tests
* feat: show external data tag in dashboards-bar for embedded dashboards * fix: disable unavailable buttons when showing embedded dashboard * chore: remove unused import * chore: fix broken unit test * feat: edit and delete embedded dashboards using a modal * refactor: encapsulate superset dashboard mutation logic in a hook * chore: remove redundant use of nsSeparator in i18n.t call
* chore: add excludeByVersionTag to cypress config and add tagify dependency * chore: allow mixing cucumber and non-cucumber specs * chore: temporarily disable all cypress-cucumber stuff * test: add cypress test for creating a superset embedded dashboard * chore: update dependencies so that cypress-tags could run * chore: disable exclude by version tags and enable cucumber preprocessor * chore: detect version during run and skip tests if below 42 * chore: keep cucumber specs separate from js specs to prevent This prevents the js spec from being included in each cucumber feature. badeball/cypress-cucumber-preprocessor#1262 * fix: close more-menu after toggling dashboard starred state * fix: ensure dashboard iframe is reloaded when dashboard embed data is updated * test: finalize e2e test suite for superset embedded dashboard feature * chore: ensure the before callback has a this scope * chore: update yarn.lock * chore: upgrade node version in all workflows Ensure it matches my local version where all tests pass * chore: adjust cypress spec path * chore: adjust test matrix so it includes both cucumber and regular cypress specs
HendrikThePendric
force-pushed
the
feat/embedded-superset-dashboards-DHIS2-17891
branch
from
47e9b85 to
a1c84ee
Compare
HendrikThePendric
changed the title
* test: add unit tests for superset embedded fields state hook * fix: use regular radio inputs in choose-dashboard-type modal * fix: apply cursor style to outer container of radio * fix: ensure selected is an object in edit dashboard unit test * fix: adjust embedded dashboard fields Since toggling the filter visibility is not working via the SDK we have removed that option. And we have replaced it with an option to expand/collapse the filters instead. * chore: remove unused import * fix: adjust buttons texts to design specs * fix: make choose-dashboard-type modal dismissable * chore: upgrade reselect * fix: use memoized selector for embedData to avoid unnecessary dashboard reloads * refactor: use ms prefix for reselect memoized selectors * fix: adjust import name * fix: add padding below description for embedded dashboards While the dashboards themselves have some whitespace above the filter controls section does not, so some whitespace below the description is needed to avoid it touching the filter controls.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements DHIS2-XXXX
Requires https://github.com/dhis2/analytics/pull/XXX
Key features
Description
text
TODO
Known issues
Screenshots
supporting text