-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(app-platform): upgrade platform tools to use vite and react 18 #107
Open
kabaros
wants to merge
7
commits into
master
Choose a base branch
from
upgrade-vite-react
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2d335c3
to
9432299
Compare
🚀 Deployed on https://pr-107--dhis2-data-exchange.netlify.app |
9432299
to
fab1a85
Compare
fab1a85
to
dab25d4
Compare
dab25d4
to
036adc1
Compare
036adc1
to
ea2fbb1
Compare
ea2fbb1
to
542d473
Compare
542d473
to
00de8cd
Compare
00de8cd
to
21b7d2d
Compare
Signed-off-by: Kai Vandivier <[email protected]>
21b7d2d
to
bf6d967
Compare
KaiVandivier
reviewed
Feb 7, 2025
Comment on lines
+640
to
+641
// ToDo: couldn't get this test working reliably after react-18/vite upgrade (and it already had an extended timeout signaling it might have been flaky) | ||
it.skip('does not post anything for ID schemes when None option is selected', async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heads up here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DHIS2-18795
Mostly automated by dhis2/app-platform#887.