feat: Add option to exclude ALL auth from check #19521
Draft
+15
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows us to exclude the
ALLauthority from an endpoint authority check.The use for this is probably very low right now, but given it's such a small change and it has no impact on the current behaviour, it seems like a nice option to be able to choose. It's a good topic for conversation at least.
We currently allow the use of
ALLto do anything in the system. A recent conversation during a merge demo brought up the topic of theALLauthority. Given that users know about theALLauthority, it is reported that a lot of users are granted theALLso they can just use the system without hassle and use features they possibly should not be allowed to.There are no endpoints that use this feature in this change, so no tests can be added yet.