chore: use EnrollmentService in TE service to get enrollements/events DHIS2-18541

[teleivo]

• use EnrollmentService in TE aggregate to fetch enrollments and events as well as to serve /trackedEntities/uid.
• temporarily fetch relationship/items eagerly using mappers and do ACL on relationships in JdbcEventStore. This is needed anyway but here its used to eagerly fetch the entities we need later on when there is no hibernate session available. See Architecture challenges for more.
• temporarily return primary key id and uid as TrackedEntityIdentifiers pair from the TE store. This is needed for now so we can pass the TE uids to the enrollment service in the enrollment aggregate. All other aggregate code uses the primary key id. We might be able to untangle the TE aggregate later on.

Next

• use exactly the same code to serve single vs multiple TEs
• change our code structure when it comes to relationships as described below (maybe in a separate ticket)

Architecture challenges

Our goal was that every service of an entity depends on its childs service to fetch such nested entities. This assumes an acyclic graph TE -> EN -> EV. This neglects the fact that relationships can add cycles. This is an example graph where relationships add edges causing cycles

We cannot have cycles in our code as Spring would not know how to resolve them unless we resort to some hacks.

This was already true. Up to now it was solved by hibernate fetching relationships. Even in services/stores that use JDBC like hibernate was ultimately responsible for getting relationships

• the JdbcEventStore
• or the DefaultTrackedEntityService which uses the JDBC based aggregate to get relationships.

We are going to stick with hibernate being responsible for fetching relationships. The target architecture will be

This will mean that there is one place that is also responsible for ACL of relationships (trackerAccessManager.canRead(user, relationship). Note that this underneath checks the ACL of TE, EN, EV.

[sonarqubecloud]

Quality Gate failed

Failed conditions
3 New issues
3 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE