-
Notifications
You must be signed in to change notification settings - Fork 3
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
To migrate to GitHub Actions and our library workflows a few changes are needed: First up, removing the .travis.yml and adding in the .github/workflows/dhis2-verify-lib.yml. The lint job is left commented out, as there are 600+ linting errors reported (all autofixable it seems), but fixing the lint errors should be in a different commit, as this needs to be backported and is designed to be easy to move to other branches. The main entrypoint in package.json was pointing to a directory that doesn't exist, so that has been updated to build/index.js. When moving to the d2-utils-release script, we will no longer publish this as a flat package, so this is potentially a breaking change. I think that it worked because the lib was compiled into build/index.js, and then since the main entrypoint in package.json did not exist, the file-loader fell back to loading the index.js from the package, which happened to exist in the root folder because of the flatpack structure in the released artifact. This should "just work" with the correct entry-point even if we no longer release the flat package. Old version of node-sass has been bumped to 4.13.1 which is close to the previous to not have any breaking changes, but supports node versions >= 10. Fix: https://jira.dhis2.org/browse/TECH-512
- Loading branch information
Showing
4 changed files
with
264 additions
and
88 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,119 @@ | ||
name: 'dhis2: verify (lib)' | ||
|
||
on: | ||
push: | ||
branches: | ||
|
||
env: | ||
GIT_AUTHOR_NAME: '@dhis2-bot' | ||
GIT_AUTHOR_EMAIL: '[email protected]' | ||
GIT_COMMITTER_NAME: '@dhis2-bot' | ||
GIT_COMMITTER_EMAIL: '[email protected]' | ||
NPM_TOKEN: ${{secrets.DHIS2_BOT_NPM_TOKEN}} | ||
GH_TOKEN: ${{secrets.DHIS2_BOT_GITHUB_TOKEN}} | ||
CI: true | ||
|
||
jobs: | ||
install: | ||
runs-on: ubuntu-latest | ||
if: "!contains(github.event.head_commit.message, '[skip ci]')" | ||
|
||
steps: | ||
- uses: actions/checkout@v2 | ||
- uses: actions/setup-node@v1 | ||
with: | ||
node-version: 12.x | ||
|
||
- uses: actions/cache@v2 | ||
id: yarn-cache # use this to check for `cache-hit` (`steps.yarn-cache.outputs.cache-hit != 'true'`) | ||
with: | ||
path: '**/node_modules' | ||
key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }} | ||
|
||
- name: Install | ||
if: steps.yarn-cache.outputs.cache-hit != 'true' | ||
run: yarn install --frozen-lockfile | ||
|
||
build: | ||
runs-on: ubuntu-latest | ||
needs: install | ||
if: "!contains(github.event.head_commit.message, '[skip ci]')" | ||
steps: | ||
- uses: actions/checkout@v2 | ||
- uses: actions/setup-node@v1 | ||
with: | ||
node-version: 12.x | ||
|
||
- uses: actions/cache@v2 | ||
id: yarn-cache | ||
with: | ||
path: '**/node_modules' | ||
key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }} | ||
|
||
- name: Build | ||
run: yarn build | ||
|
||
- uses: actions/upload-artifact@v2 | ||
with: | ||
name: lib-build | ||
path: | | ||
**/build | ||
!**/node_modules | ||
retention-days: 1 | ||
|
||
#lint: | ||
# runs-on: ubuntu-latest | ||
# needs: install | ||
# if: "!contains(github.event.head_commit.message, '[skip ci]')" | ||
# steps: | ||
# - uses: actions/checkout@v2 | ||
# - uses: actions/setup-node@v1 | ||
# with: | ||
# node-version: 12.x | ||
# | ||
# - uses: actions/cache@v2 | ||
# id: yarn-cache | ||
# with: | ||
# path: '**/node_modules' | ||
# key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }} | ||
# | ||
# - name: Lint | ||
# run: yarn lint | ||
|
||
test: | ||
runs-on: ubuntu-latest | ||
needs: [install, build] | ||
if: "!contains(github.event.head_commit.message, '[skip ci]')" | ||
steps: | ||
- uses: actions/checkout@v2 | ||
- uses: actions/setup-node@v1 | ||
with: | ||
node-version: 12.x | ||
|
||
- uses: actions/cache@v2 | ||
id: yarn-cache | ||
with: | ||
path: '**/node_modules' | ||
key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }} | ||
|
||
- name: Test | ||
run: yarn test | ||
|
||
publish: | ||
runs-on: ubuntu-latest | ||
needs: [build, test] # lint commented out | ||
if: "!contains(github.event.head_commit.message, '[skip ci]')" | ||
steps: | ||
- uses: actions/checkout@v2 | ||
with: | ||
token: ${{env.GH_TOKEN}} | ||
- uses: actions/setup-node@v1 | ||
with: | ||
node-version: 12.x | ||
|
||
- uses: actions/download-artifact@v2 | ||
with: | ||
name: lib-build | ||
|
||
- name: Publish to NPM | ||
run: npx @dhis2/cli-utils release --publish npm |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.