Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle undefined apiVersion from api/loginConfig #49

Merged
merged 3 commits into from
Oct 1, 2024

Conversation

tomzemp
Copy link
Member

@tomzemp tomzemp commented Sep 27, 2024

The apiVersion in api/loginConfig appears not always to be populated properly.

This PR updates the @dhis2/cli-app-scripts to incorporate this change: dhis2/app-platform@dc7bdfa#diff-113d225207bf5868bc80a76be8f1d7bd9eeaa06c184a8605ffb80bb78cf16e64R116-R118

With this update, the app will fall back to version 41 if no version is accessible from api/loginConfig.

@tomzemp tomzemp requested a review from a team September 27, 2024 06:59
@@ -1,7 +1,4 @@
import '@testing-library/jest-dom'
import { configure } from 'enzyme'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got errors about TextEncoder being undefined after the update of cli-app-scripts (which seems to be a jest-dom v16 issue), but this setup was copied from another app and isn't needed, so I've just removed it to work around that issue.

Copy link
Member

@Chisomchima Chisomchima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tomzemp tomzemp merged commit c30055a into main Oct 1, 2024
5 checks passed
dhis2-bot added a commit that referenced this pull request Oct 2, 2024
## [100.1.10](v100.1.9...v100.1.10) (2024-10-02)

### Bug Fixes

* handle undefined apiVersion from api/loginConfig ([LIBS-683] [#49](#49)) ([c30055a](c30055a))
* test repo settings update ([d1cbe83](d1cbe83))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants