fix(data-integrity): change default report type to summary #603
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the defaultValue of
Report
type forData integrity
job to besummary
instead ofreport
.Report is a legacy type, and isn't really useful at all when scheduling. So we may remove this completely.
Also fixes a bug where I'd used
initialValue
for the field instead ofdefaultValue
. This is the wrong prop to use it in this case. BecauseinitialValue
would override theinitialValues
on the form, and meant this field would always be set toreport
when you edited a job. Which is actually a quite bad bug.I just discovered this bug when trying to schedule summary jobs in conjunction with the new Data Integrity UI in
Data Administration
app.However, this bug does not seem to happen in 2.39 and 2.38. I am not sure what introduced it, but it seems like it's currectly in 2.40 and master/dev.
Also updated
Run all available checks
-label toRun all standard checks
. Becauseslow: true
-checks will not be run this is selected, so right now it's quite misleading.Standard
is the term used inData Administration
UI for checks that are not slow.