Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(data-integrity): change default report type to summary #603

Merged
merged 2 commits into from
Mar 13, 2024

Conversation

Birkbjo
Copy link
Member

@Birkbjo Birkbjo commented Mar 11, 2024

Changes the defaultValue of Report type for Data integrity job to be summary instead of report.
Report is a legacy type, and isn't really useful at all when scheduling. So we may remove this completely.

Also fixes a bug where I'd used initialValue for the field instead of defaultValue. This is the wrong prop to use it in this case. Because initialValue would override the initialValues on the form, and meant this field would always be set to report when you edited a job. Which is actually a quite bad bug.
I just discovered this bug when trying to schedule summary jobs in conjunction with the new Data Integrity UI in Data Administration app.
However, this bug does not seem to happen in 2.39 and 2.38. I am not sure what introduced it, but it seems like it's currectly in 2.40 and master/dev.

Also updated Run all available checks-label to Run all standard checks. Because slow: true-checks will not be run this is selected, so right now it's quite misleading. Standard is the term used in Data Administration UI for checks that are not slow.

@Birkbjo Birkbjo requested review from a team as code owners March 11, 2024 14:54
@dhis2-bot
Copy link
Contributor

dhis2-bot commented Mar 11, 2024

🚀 Deployed on https://pr-603--dhis2-scheduler.netlify.app

@dhis2-bot dhis2-bot temporarily deployed to netlify March 11, 2024 14:58 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify March 11, 2024 16:07 Inactive
@Birkbjo Birkbjo force-pushed the fix/data-integrity-default-summary branch from 22a02bd to 54cc980 Compare March 11, 2024 20:33
@dhis2-bot dhis2-bot temporarily deployed to netlify March 11, 2024 20:34 Inactive
@Birkbjo Birkbjo requested a review from ismay March 11, 2024 21:02
@ismay
Copy link
Contributor

ismay commented Mar 12, 2024

Thanks, yeah that looks good to me. I'm not seeing this change btw.:

Also updated Run all available checks-label to Run all standard checks. Because slow: true-checks will not be run this is selected, so right now it's quite misleading. Standard is the term used in Data Administration UI for checks that are not slow.

@Birkbjo
Copy link
Member Author

Birkbjo commented Mar 12, 2024

Thanks, yeah that looks good to me. I'm not seeing this change btw.:

Also updated Run all available checks-label to Run all standard checks. Because slow: true-checks will not be run this is selected, so right now it's quite misleading. Standard is the term used in Data Administration UI for checks that are not slow.

Ah, sorry that was part of the other PR. Must've confused these...

@Birkbjo Birkbjo merged commit 1e27b04 into master Mar 13, 2024
9 checks passed
@Birkbjo Birkbjo deleted the fix/data-integrity-default-summary branch March 13, 2024 13:53
dhis2-bot added a commit that referenced this pull request Mar 13, 2024
## [101.5.2](v101.5.1...v101.5.2) (2024-03-13)

### Bug Fixes

* **data-integrity:** add indicator for slow checks ([#604](#604)) ([a4b7802](a4b7802))
* **data-integrity:** change default report type to summary ([#603](#603)) [defer release] ([1e27b04](1e27b04))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 101.5.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants