Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove oauth2 config [DHIS2-15326] #1269

Merged
merged 1 commit into from
Sep 28, 2023
Merged

fix: remove oauth2 config [DHIS2-15326] #1269

merged 1 commit into from
Sep 28, 2023

Conversation

tomzemp
Copy link
Member

@tomzemp tomzemp commented Sep 26, 2023

This PR removes oauth2 client configuration from the settings app (v41) because this will be a deprecated feature: https://github.com/dhis2/dhis2-releases/blob/master/releases/deprecated-features.md (spoke with Morten S about this)

See https://dhis2.atlassian.net/jira/software/c/projects/DHIS2/issues/DHIS2-15326

@dhis2-bot
Copy link
Contributor

🚀 Deployed on https://pr-1269--dhis2-settings.netlify.app

@tomzemp tomzemp requested a review from a team September 26, 2023 09:43
@KaiVandivier
Copy link
Contributor

What do you think about removing this feature in a feature-toggling way, so that future versions of this app can still be used on lower DHIS2 versions?

@tomzemp
Copy link
Member Author

tomzemp commented Sep 26, 2023 •
edited
Loading

What do you think about removing this feature in a feature-toggling way, so that future versions of this app can still be used on lower DHIS2 versions?

@KaiVandivier: I don't know? We could do that, but this app currently has separate versions, and it seems like we don't do feature toggling on versioned apps? I'm not sure if it becomes more confusing if you look at version-specific code and see feature toggling logic?

Joe also mentioned that the settings app is a candidate to be redesigned, so I hope in the future that we will eventually replace the current app with an updated continuous release app.

KaiVandivier
KaiVandivier approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@KaiVandivier KaiVandivier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yeah you're right, this is a core-version-specific app -- my bad!

This looks good then 😊

@tomzemp tomzemp merged commit e3e7b57 into master Sep 28, 2023
8 checks passed
@tomzemp tomzemp deleted the DHIS2-15326/remove-oauth2-clients branch September 28, 2023 11:46
dhis2-bot added a commit that referenced this pull request Sep 28, 2023
@dhis2-bot
chore(release): cut 29.15.5 [skip ci]
ec2fb11 
## [29.15.5](v29.15.4...v29.15.5) (2023-09-28)

### Bug Fixes

* remove oauth2 config [DHIS2-15326] ([#1269](#1269)) ([e3e7b57](e3e7b57))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 29.15.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@tomzemp tomzemp mentioned this pull request Feb 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KaiVandivier KaiVandivier KaiVandivier approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomzemp @dhis2-bot @KaiVandivier