Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update info icons #1290

Merged
merged 1 commit into from
Dec 14, 2023
Merged

fix: update info icons #1290

merged 1 commit into from
Dec 14, 2023

Conversation

tomzemp
Copy link
Member

@tomzemp tomzemp commented Dec 13, 2023

See https://dhis2.atlassian.net/browse/DHIS2-10834

This updates the information icons so that they are not using a button. I've also updated to use our own Tooltip component and have lightly updated the existing CSS to get them in alignment (I did not want to do more comprehensive CSS updates, so this is a bit eyeballed)

Before
image

After
image

@dhis2-bot
Copy link
Contributor

🚀 Deployed on https://pr-1290--dhis2-settings.netlify.app

Copy link
Contributor

@KaiVandivier KaiVandivier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool looks good 🙂 👍

@tomzemp tomzemp merged commit 6448044 into master Dec 14, 2023
9 checks passed
@tomzemp tomzemp deleted the DHIS2-10834/fix-information-buttons branch December 14, 2023 15:07
dhis2-bot added a commit that referenced this pull request Dec 14, 2023
## [29.15.9](v29.15.8...v29.15.9) (2023-12-14)

### Bug Fixes

* update info icons ([#1290](#1290)) ([6448044](6448044))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 29.15.9 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants